Skip to content

some minor settings cleanup #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

some minor settings cleanup #6695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .env-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,3 @@ REUSE_DB=0
ENABLE_ADMIN=True
SET_LOCALE_PATH=False
SECURE_SSL_REDIRECT=False
GOOGLE_APPLICATION_CREDENTIALS=creds
GOOGLE_CLOUD_PROJECT=sumo-test
6 changes: 4 additions & 2 deletions kitsune/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,9 +1337,11 @@ def filter_exceptions(event, hint):

USER_INACTIVITY_DAYS = config("USER_INACTIVITY_DAYS", default=1095, cast=int)

if DEV:
GOOGLE_APPLICATION_CREDENTIALS = config("GOOGLE_APPLICATION_CREDENTIALS", default="")
# GOOGLE_CLOUD_PROJECT is required for making LLM calls.
GOOGLE_CLOUD_PROJECT = config("GOOGLE_CLOUD_PROJECT", default="")
# GOOGLE_APPLICATION_CREDENTIALS is necessary only for making LLM calls during local
# development. It should NEVER be defined for the dev, stage, and prod environments.
GOOGLE_APPLICATION_CREDENTIALS = config("GOOGLE_APPLICATION_CREDENTIALS", default="")

# shell_plus conf
SHELL_PLUS_DONT_LOAD = ["silk"]